[media] fix centerID #9469
Closed
[media] fix centerID #9469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongtiaowang
added
the
Category: Bug
|
What version of PHP are you running? CenterID is an integer database column. It should already be returned as an int by the PDO. These changes look unnecessary and may break when the value is null (in which case a CenterID class for CenterID 0 will be returned.) |
|
I am using php 8.3.12. to produce the issue: create a new user then login media module, it will got this error. |
|
[media] fix non-admin user login error #9477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
produce the issue: create a new user then login media module, it will got this error below.
[media] fix centerID::singleton(int ...)
PHP Fatal error: Uncaught TypeError: CenterID::singleton(): Argument #1 ($id) must be of type int, string given,