[NDB_BVL_Instrument] Modify Examiner Select #9452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you split this in 2? The test_names looks like an easy bug fix, the "DISTINCT" seems more questionable. Why aren't they already distinct? |
I'll split it up. I am not sure why they are not already distinct, but this is an override that we needed in CCNA as without it the recreate_conflicts script fails: |
skarya22
changed the title
ridz1208
approved these changes
Nov 27, 2024
ridz1208
reviewed
Nov 27, 2024
| @@ -1053,7 +1053,7 @@ abstract class NDB_BVL_Instrument extends NDB_Page | |||
| ['tst_name' => $this->testName] | |||
| ); | |||
| $results = $db->pselectWithIndexKey( | |||
| "SELECT c.examinerID, e.full_name, u.Email | |||
| "SELECT DISTINCT c.examinerID, e.full_name, u.Email | |||
There was a problem hiding this comment.
@skarya22 I don't think this DISTINCT is necessary since you are querying by CenterID but I don't see any way it would hurt so.. I'm okai with it
maximemulder
added
Area: Instruments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
CCNA OVERRIDE PR