Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publication] Fix for auto-selecting Project in edit #9187

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • The value expected by the field is the number id, but the fetch statement was returning the name - so I modified the sql statement to fetch the project ID.

Testing instructions (if applicable)

  1. Propose a new project in the publication module and remember the project name
  2. Submit and then go back to the main module and select it and make sure the project is auto selected

Link(s) to related issue(s)

@jeffersoncasimir jeffersoncasimir self-assigned this Apr 8, 2024
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue as described. The project no longer seems "unassigned" when Editing.

However, this solution introduces an issue where when Viewing a project, the ID is displayed instead of the name:

Screenshot 2024-04-08 at 10 20 06 AM

@skarya22
Copy link
Contributor Author

@jeffersoncasimir thank you for catching that. I have fixed it to work in edit, viewing, and submitting a new publication.

@jeffersoncasimir jeffersoncasimir added the Passed manual tests PR has been successfully tested by at least one peer label Apr 16, 2024
@jeffersoncasimir
Copy link
Contributor

Works as expected!

@driusan driusan merged commit 5b5170a into aces:main Apr 16, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[publication] Project unselected on-edit
4 participants