[new_profile] fix site not selecting automatically when 'Recruit anot… #9177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2024 16:16
…her candidate' button is clicked
shonibare
added
the
26.0.0-bugs
ridz1208
previously requested changes
Mar 27, 2024
There was a problem hiding this comment.
@shonibare Although this fix might make it look like its working properly I'm not convinced its the correct fix.
According to #6156
It seems like an autoselect prop was added to select fields that should accomplish that instead of force loading the site from the previous formdata. To do so it seems like what you need is to retrigger the rende of the select element (not sure how but maybe resetting the fieldoptions state would do it). Alternatively (and I'm really not the expert here) but I think we could reload the page and it should reset the state to what it was the first time we loaded it..
|
@ridz1208 reloading the page works! |
|
The issue was fixed by #9197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...her candidate' button is clicked
fixes #9146