Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[media] 413 error improperly handled #9163 - fix #9175

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

kongtiaowang
Copy link
Contributor

Brief summary of changes

[media] 413 error improperly handled #9163

Testing instructions (if applicable)

upload a large file more than 1 GB file, it will show the error message.
截屏2024-03-27 下午1 17 13

@kongtiaowang kongtiaowang added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Mar 27, 2024
@CamilleBeau CamilleBeau self-requested a review April 4, 2024 14:45
@CamilleBeau CamilleBeau self-assigned this Apr 4, 2024
@CamilleBeau
Copy link
Contributor

I followed these steps:

  • Check out this branch
  • Compile media module
  • Change max upload size to 10M
  • Upload file greater than 10M

I got this error message:
image

@CamilleBeau CamilleBeau added the State: Needs work PR awaiting additional work by the author to proceed label Apr 4, 2024
@kongtiaowang kongtiaowang removed the State: Needs work PR awaiting additional work by the author to proceed label Apr 8, 2024
@kongtiaowang kongtiaowang force-pushed the 2024-03-27-media-fix branch from cebfb7e to 5c1f852 Compare April 9, 2024 03:40
@kongtiaowang kongtiaowang force-pushed the 2024-03-27-media-fix branch from b9569dd to 0ba1b98 Compare April 9, 2024 03:58
@kongtiaowang
Copy link
Contributor Author

@CamilleBeau Could you re-test it? This time you will get more details about the upload error.

@CamilleBeau
Copy link
Contributor

Strangely, I'm still getting an error message that does not indicate file too large:
image

I set the upload_max_filesize in /etc/php/8.1/apache2/php.ini to 10MB and uploaded a file of 15 MB.

@regisoc
Copy link
Contributor

regisoc commented Apr 11, 2024

Referencing it here because this issue might be linked.
#9174

@CamilleBeau
Copy link
Contributor

Passing manual tests now

@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Apr 16, 2024
@driusan driusan merged commit f96d9e4 into aces:main Apr 16, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants