EEGVisEnabled check issue and webpack cache #9159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laemtl
commented
Mar 21, 2024
•
laemtl
commented
- Fix a WebpackMissingModule error with the EEGBrowser when EEGVisEnabled is set to "1" | "0" instead of "true" | "false".
- Turn the webpack cache to off as it contributes to the heap memory issues for users with less than 2GB Ram. In dev mode, all cache is stored in memory. Alternatively, if build speed is impacted, it can also be set to filesystem.
kongtiaowang
added
the
26.0.0-bugs
|
What does "and webpack cache" mean? Why is the |
|
Sorry, I forgot to explain that change in the description. Updated. |
|
@GeorgeMurad can you test if this branch fixes your memory issue problems when running @laemtl is there any reason not to change it to cache to the filesystem instead of disabling it entirely? |
No, it might be a good option as well, maybe a better compromise. |
3 tasks
christinerogers
added
the
Critical to release
|
resolution of this issue is critical to release for the EEG Browser (signal display breaks if not #9160 ) |
|
@laemtl could you make the change for filesystem cache |
laemtl
force-pushed
the
EEGVisEnabled-check-issue-and-webpack-cache
branch
2 times, most recently
from
6f95b62
to
0049008
Compare
|
@ridz1208 Done |
|
@laemtl the static tests are failing |
laemtl
force-pushed
the
EEGVisEnabled-check-issue-and-webpack-cache
branch
from
0049008
to
94974f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.