Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix db installer host name #9107

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix db installer host name #9107

merged 2 commits into from
Mar 11, 2024

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Feb 28, 2024

Brief summary of changes

Fix the database installer so that the 'Host' field name matches the name found in the database. This difference prevented Loris from being installed on systems in which the database returns tables whose field names are capitalized according to their name in the database, and not in the query (our dev VMs does the latter, hence why we did not have this bug during development).

Testing instructions

Run the database installer on a system with a database whose returned field names are not capitalized according to the query.

Links to related issues

@driusan
Copy link
Collaborator

driusan commented Feb 28, 2024

@nicolasbrossard can you review and test?

@ridz1208
Copy link
Collaborator

ridz1208 commented Mar 7, 2024

@maximemulder changes look good, pending check on other locations to approve

@maximemulder
Copy link
Contributor Author

maximemulder commented Mar 7, 2024

@maximemulder changes look good, pending check on other locations to approve

Done (I probably should have done that before tbh, my fault). I also looked for other uses of mysql.user elsewhere in the code, but I did not find any (search mysql.user / `mysql`.`user`).

Also, as explained in the following comment, this change must be tested on MariaDB >= 10.4
#9101 (comment)
Considering the root cause has been found, I think the issue can be closed once this PR is mergred.

@driusan driusan merged commit 0498fcb into aces:main Mar 11, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
@maximemulder maximemulder deleted the fix-db-installer branch October 29, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants