-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electrophysiology_browser] Revised EEG filters + Store reference fix #9038
Merged
driusan
merged 11 commits into
aces:main
from
jeffersoncasimir:2024_02_01_eeg_revised_filters
Feb 29, 2024
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
804c524
Add samplingFrequency reference + Revised coefficients
jeffersoncasimir f91a53f
Add multiple store references for cases with multiple recordings
jeffersoncasimir 8c0e437
Satisfy linter
jeffersoncasimir 2a6b8d4
Removed 'AssembledHED' column from RB inserts
jeffersoncasimir 1471f74
Revert "Removed 'AssembledHED' column from RB inserts"
jeffersoncasimir 909aa3b
Fix parameter order
jeffersoncasimir 791c819
Merge branch 'main' into 2024_02_01_eeg_revised_filters
jeffersoncasimir bac09ce
Add proper typing to ResponsiveViewer
jeffersoncasimir ec2568e
Removed @ts-ignore directives
jeffersoncasimir af90903
Removed @ts-ignore directive
jeffersoncasimir dece67f
Removed unused property
jeffersoncasimir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being ignored? If ts flags something it's usually for a reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why. It was not introduced by this PR (or myself) and there seems to be many instances of
// @ts-ignore
throughout the moduleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? This line is being introduced by you in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. However it is also present 11 lines above, as well as in the other
<ResponsiveViewer>
component inSeriesRenderer.tsx
.It seems to be related to
export default withParentSize(ResponsiveViewer)
at the end ofResponsiveViewer.tsx
.Here is the error I get when I remove the
// @ts-ignore
line you pointed out (different branch, but refers to same place):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a real error that needs to be investigated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I found an appropriate solution. It has been pushed to this PR.