[Tools] fix timepoint data problems #8949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecours
changed the title
|
I think this needs to be rebased? Seems to have a lot of unrelated changes (and 3 files with conflicts..) |
delegate EDC check to Timepoint class
xlecours
force-pushed
the
20231114_Issue5040_fix_timepoint_data_problems
branch
from
0914c52
to
1f78862
Compare
CamilleBeau
approved these changes
Dec 1, 2023
CamilleBeau
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5040
The script now uses 'Other' has Feedback type instead of the one with id
5(Which was failing due to foreign key constraint if there was no feedback type with id = 5)Also remove the part where the date of birth was determined based on the Subproject/Cohort id 1 or 2 (which does not mean anything) and now relies on Timepoint::getEffectiveDateOfBirth. I assumed that subproject 1 and 2 was making a distinction between pre ans post natal visits. Timepoint::getEffectiveDateOfBirth should handle that.