[LINST] fix survey and date issues #8858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good. |
ridz1208
commented
Aug 10, 2023
| @@ -98,7 +98,9 @@ class NDB_BVL_Instrument_LINST extends \NDB_BVL_Instrument | |||
| ] | |||
| ); | |||
|
|
|||
| if (strrpos($this->testName ?? '', '_proband') === false) { | |||
| if (strrpos($this->testName ?? '', '_proband') === false | |||
There was a problem hiding this comment.
consider moving this up
charliehenrib
added
the
State: Needs work
ridz1208
removed
the
State: Needs work
|
@CamilleBeau @charliehenrib @laemtl removed the change relating to age on direct instruments, I'll make a PR just for that for the remaining changes I think what needs to be tested is to have a LINST instruments with 3 different types of dates |
zaliqarosli
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zaliqarosli some changes derived from the QPN overrides that I believe apply to LORIS