Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/api] Add tests for getting instrument data from API. #8810

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Jun 21, 2023

The previous test was "incomplete" (it sent a request to the URL but didn't do anything to verify it.) This adds real tests for the candidate instrument data endpoint now that Issue #8781 was fixed by PR#8796.

Also resolves #8804 point 1. (Point 2 was resolved by #8805)

The previous test was "incomplete" (it got the data but didn't
do anything to verify it.) This adds real tests for the candidate
instrument data endpoint now that Issue aces#8781 was fixed by PR#8796.
@driusan driusan added Testing PR contains test plan or automated test code (or config files for Travis) Area: API PR or issue related to the API labels Jun 21, 2023
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 5221cf0 into aces:25.0-release Jul 4, 2023
@ridz1208 ridz1208 added this to the 25.0.0 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API PR or issue related to the API Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants