[bvl_feedback] Edit comment section #8790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarya22
added
the
State: Needs work
skarya22
removed
the
State: Needs work
driusan
reviewed
Aug 16, 2023
Co-authored-by: Dave MacFarlane <[email protected]>
kongtiaowang
pushed a commit
to kongtiaowang/Loris
that referenced
this pull request
Nov 29, 2023
Fix display of bvl_feedback on mobile devices. - Switched Add Comment button from Pencil to a Comment (Original was confusing) - Set threads to be shown automatically for open threads as having them hidden made the UI confusing. - Added an Edit and Delete button for comments of which the author is the user viewing them - Flipped the order of comments around so that the newer comments show up below. Makes more sense when reading the comments - Made New Comment TextArea section show up below the thread, as that is where the new comment will appear - Changed panel width to work on mobile devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Before:
Comment section
Behaviour:
Mobile device
(Everything is cut off)
After:
Behaviour:
Mobile device