[candidate_list] Multiselect for visit label, site, and cohort #8730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me.. @racostas could you review/test? |
racostas
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
LGTM.
There is a small typo in the description of the PR but all fine
in place of:
2. Check that you can select multiple visit labels, cohorts, and visits
Should be;
2. Check that you can select multiple visit labels, cohorts, and sites
Should this one go to 25 @driusan ?
racostas
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
The filters for site, cohort and visit label are now multiselect
Testing instructions (if applicable)
Note
This is a CCNA override - https://github.com/aces/CCNA/pull/3922