Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
When a dob Format of Ym (year and month without day) is set in the config module, candidates could not be created for 2 reasons.
!Y-m-d
) was being passed through the functionDateTime::createFromFormat
in thecreateNew
function of the candidate class, which gave a wrong format error to the user even if they were passing through the expected format of Year-monthdate
This PR fixes this issue by getting the date format from config, processing it to the right format and passing it through to
DateTime::createFromFormat
, as well as adding a '-01' to the end of the date if Ym format is selected in the configuration. This inserts the first of the month as the arbitrary date for a candidate.Would someone be able to help me out as to whether this should be added to the changelog? I'm not sure if this is a bug introduced in 25 but I would be surprised if it existed in previous versions since it is so critical.
Testing instructions (if applicable)
Link(s) to related issue(s)