[battery_manager] use visit controller to fetch visit list

[ridz1208]

Brief summary of changes

The battery manager currently uses the Utility::getVisitList() function to list the visits available. That utility function queries the session table for existing visitlabels used in at least one session. That is problematic when you are creating a new visit and new instruments and want to assign instruments to the new visit, it simply does not show up in the drop down.

This PR fixes that problem and removes the use of Utility::getInstrumentList to get an accurate list of full names for instruments and get rid of deprecation warnings

• Resolves [battery manager] Get list of visits from visits table not session #8459

[KLaFleur]

When I try this out, the dropdowns which should show the visits (V1,V2,V3, etc) just return the default js object serialization [object Object] a screenshot is attached below. It's possible this is due to a database issue on my end, but I'm not sure what that'd be.

[ridz1208]

@KLaFleur this is interesting. The list I was modifying is the one under the "add test" modal window. can you test if that one is working and if not I can take a look at whats happening

[KLaFleur]

I was getting the same behavior on the ‘add test’ window as well — I can check again to confirm that but I’m 99% sure that was the case. Le sam. 29 avr. 2023 à 12:41 PM, Rida Abou-Haidar ***@***.***> a écrit :

…

@KLaFleur <https://github.com/KLaFleur> this is interesting. The list I was modifying is the one under the "add test" modal window. can you test if that one is working and if not I can take a look at whats happening — Reply to this email directly, view it on GitHub <#8485 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIL6HW6N5K3AFRXTSFOB3ITXDVAB7ANCNFSM6AAAAAAWK4F7BU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ridz1208]

@KLaFleur could you test again please

[KLaFleur]

Yes just tested (in both the general filter and in the 'new test' window, the dropdown works and the list looks complete!

…

On Tue, Jun 20, 2023 at 11:10 AM Rida Abou-Haidar ***@***.***> wrote: @KLaFleur <https://github.com/KLaFleur> could you test again please — Reply to this email directly, view it on GitHub <#8485 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIL6HW455XFZARBLYE4LR6TXMG4PJANCNFSM6AAAAAAWK4F7BU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ridz1208]

@KLaFleur take a look at the code and try to spot any issues. @driusan will do a secondary review after. when you take a look at the code, if all is well make sure to "Approve" the PR