[Issue tracker] change userID to full name #8451
Conversation
|
@regisoc in this file issue_tracker/test/Issue_TrackerTest.php add [ 'assignee' => 'TestUser', ] after line 63, it will pass test. |
|
Hi @regisoc , let's add the changes to the CHANGELOG file for keeping track https://github.com/aces/Loris/blob/main/CHANGELOG.md |
| @@ -429,7 +452,7 @@ class Edit extends \NDB_Page implements ETagCalculator | |||
|
|
|||
| $issueID = intval($values['issueID']); | |||
|
|
|||
| $issueValues['lastUpdatedBy'] = $user->getUsername(); | |||
| $issueValues['lastUpdatedBy'] = $user->getUserName(); | |||
There was a problem hiding this comment.
since it is assigned in line 483 I think this input in 455 is not longer necessary .
There was a problem hiding this comment.
It will be because it is used in line 473 (update on existing issue case) and 477 (new issue case).
This needed to be the username (userID) for the issues table. The value is just changed for the full name after database insert/update (line 483).
There was a problem hiding this comment.
I see, yes, it's a bit confusing the way the code is wrote but I think this precedes this PR. For example $historyValues is assigned in 470 the used in 486, passing the DB updated in between without using the value :)
The PR is fine !
racostas
added
the
Passed manual tests
Brief summary of changes
Change user IDs to user full names throughout the main pages.
Testing instructions (if applicable)
assigneeandreportercolumns in the main table (there should be user full names).