Make the number of days since last login before making a user inactive a config #8416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Category: Feature
cmadjar
changed the title
ridz1208
reviewed
Mar 1, 2023
| @@ -356,7 +361,8 @@ class SinglePointLogin | |||
| } | |||
|
|
|||
| if ($row['Active'] == 'N' | |||
| || $this->disabledDueToInactivity($username, 365) | |||
| || ($maxDaysInactive | |||
There was a problem hiding this comment.
because of the not-so-predictable behaviour of intval(), I would instead do a more explicit check like (!empty($maxDaysInactive) && is_numeric($maxDaysInactive))
intval:
Return Values ¶
The integer value of value on success, or 0 on failure. Empty arrays return 0, non-empty arrays return 1.
The maximum value depends on the system. 32 bit systems have a maximum signed integer range of -2147483648 to 2147483647. So for example on such a system, intval('1000000000000') will return 2147483647. The maximum signed integer value for 64 bit systems is 9223372036854775807.
Strings will most likely return 0 although this depends on the leftmost characters of the string. The common rules of integer casting apply
ridz1208
reviewed
Mar 1, 2023
|
@ridz1208 Thanks for the quick review! Your comments should be addressed and I added a note to the roadmap call to discuss whether it is OK to have |
|
@cmadjar needs rebase, conflicts. |
add default value to config fix phrasing of the config to something hopefully clearer modify RB to add the new config
cmadjar
force-pushed
the
make_nb_of_days_inactive_before_making_user_inactive_a_config
branch
from
6549aef
to
4368970
Compare
|
@cmadjar seems like there's a problem with the tests on this PR, can you look into it when you get a chance? |
|
@driusan this passes the tests now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This adds a new Config in the config module to allow projects to configure the number of days since a user last logged in before making their account inactive.
Testing instructions
SQL/New_patches/2023-02-28_create_max_days_inactive_config_for_users.sqlUPDATE user_login_history SET Login_timestamp='2020-02-28 19:28:35' WHERE userID=<new user id>