Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instruments] Display Candidate Age at Death if postMortem is true #8362

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

zaliqarosli
Copy link
Contributor

@zaliqarosli zaliqarosli commented Feb 6, 2023

Brief summary of changes

This PR:

  • fixes the Candidate Age at Death field label and Data Dictionary item for LINST instruments

  • adds postMortem functionality for LINST instruments

  • solidifies workflow for when Candidate Age at Death is displayed vs. Candidate Age (only when postMortem variable is set to true, and is independent of whether candidate has DoD or not - it is truly an instrument configuration and not dependent on instrument/candidate data)

  • adds this workflow/configuration to the instruments module testplan and readme

  • Have you updated related documentation?

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@zaliqarosli zaliqarosli changed the title [instruments] Fix Candidate Age at Death display if $this->postMortem is true [instruments] Display Candidate Age at Death if postMortem is true Feb 6, 2023
@laemtl laemtl assigned kongtiaowang and unassigned kongtiaowang Feb 21, 2023
@zaliqarosli zaliqarosli added Area: UI PR or issue related to the user interface Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) labels Feb 21, 2023
@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 14b26c7 into aces:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI PR or issue related to the user interface Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Instruments] Correct/Update TestPlan and Readme for DoD feature / linst
4 participants