Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[survey_accounts] Clean up after Email col removed #8313

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

zaliqarosli
Copy link
Contributor

Brief summary of changes

  • Have you updated related documentation?

The Email column of the participant_accounts table was removed in #7248.
This PR cleans up the remaining references to that column, and removes from the schema/raisinbread

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@zaliqarosli zaliqarosli added the Cleanup PR or issue introducing/requiring at least one clean-up operation label Jan 5, 2023
@driusan
Copy link
Collaborator

driusan commented Jan 5, 2023

Seems to be missing an SQL/Cleanup_patches/ patch (I doubled checked and I don't see one already there either.)

@zaliqarosli
Copy link
Contributor Author

@driusan its been archived https://github.com/aces/Loris/blob/main/SQL/Archive/21.0/Cleanup/2020-12-18-Remove_survey_emails.sql

@driusan
Copy link
Collaborator

driusan commented Jan 5, 2023

@ridz1208 are we supposed to archive cleanup patches? I thought the point of them were that they're run at your discretion outside of the release cycle.

@ridz1208
Copy link
Collaborator

ridz1208 commented Jan 5, 2023

@driusan I think we are archiving them so they dont grow into a eternal list, basically to know which patches were added for which release but they are optional yes

@zaliqarosli
Copy link
Contributor Author

zaliqarosli commented Jan 5, 2023

@driusan @ridz1208 it is true though that the patch was never added to Cleanup_patches dir for the releases it was tagged on, the patch went straight to archive. would it need to be added there?
https://github.com/aces/Loris/tree/v21.0.7/SQL/Cleanup_patches and https://github.com/aces/Loris/tree/v22.0.4/SQL/Cleanup_patches

@zaliqarosli zaliqarosli reopened this Jan 12, 2023
@driusan driusan merged commit 86a0494 into aces:main Feb 14, 2023
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants