Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard/statistics] react widgets instead of smarty, new panel.js and use npm version of c3 & d3 #8261

Closed
wants to merge 58 commits into from
Closed

[dashboard/statistics] react widgets instead of smarty, new panel.js and use npm version of c3 & d3 #8261

wants to merge 58 commits into from

Conversation

maltheism
Copy link
Member

@maltheism maltheism commented Dec 7, 2022 •
edited
Loading

Brief summary of changes

Context: CCNA had loading issues of the dashboard because of the smarty widgets. Solved by getting the statistics data after the frontend is loaded.

Updates:

  • new panel component that handles multiple views.
  • Instead of smarty we'll use react for the statistics widgets.
  • Update the c3 & d3 graph generation to use the npm version.

Testing instructions (if applicable)

  1. checkout pr
  2. make clean && make dev
  3. visit the dashboard
  4. look at the widgets

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@maltheism maltheism added the State: Needs work PR awaiting additional work by the author to proceed label Dec 7, 2022
@maltheism maltheism changed the title [dashboard/statistics] remove smarty, convert to react widgets, new panel.js and use npm version of c3 & d3 [dashboard/statistics] react widgets instead of smarty, remove jQuery usage, new panel.js and use npm version of c3 & d3 Dec 9, 2022
@maltheism maltheism changed the title [dashboard/statistics] react widgets instead of smarty, remove jQuery usage, new panel.js and use npm version of c3 & d3 [dashboard/statistics] react widgets instead of smarty, new panel.js and use npm version of c3 & d3 Dec 9, 2022
@maltheism maltheism added the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Dec 9, 2022
@maltheism maltheism mentioned this pull request Dec 20, 2022
Merged
@maltheism maltheism added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Dec 20, 2022
@maltheism
Copy link
Member Author

PR blocked by #8299

@maltheism maltheism removed State: Needs work PR awaiting additional work by the author to proceed "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help labels Dec 20, 2022
@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
@ridz1208 ridz1208 assigned CamilleBeau and unassigned maltheism Mar 21, 2023
@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Mar 22, 2023
@laemtl laemtl removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Mar 23, 2023
@laemtl laemtl marked this pull request as ready for review March 23, 2023 14:52
@laemtl laemtl mentioned this pull request Mar 23, 2023
Merged
@laemtl
Copy link
Contributor

laemtl commented Mar 23, 2023

Replaced by #8476

@laemtl laemtl closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamilleBeau CamilleBeau CamilleBeau approved these changes

@laemtl laemtl Awaiting requested review from laemtl

@driusan driusan Awaiting requested review from driusan

Assignees

@CamilleBeau CamilleBeau

Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation dependencies PR that updates dependency files Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maltheism @laemtl @CamilleBeau @haoweiqiu