Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bvl_feedback][dashboard] Add project/site specs to widget #7848

Merged
merged 3 commits into from
Dec 13, 2022
Merged

[bvl_feedback][dashboard] Add project/site specs to widget #7848

merged 3 commits into from
Dec 13, 2022

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Nov 23, 2021 •
edited
Loading

Brief summary of changes

This PR changes the getWidget code so that a user only sees behavioural feedback notifications relevant to their own sites (unless they have the access all sites permission) / projects.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Login with a user who only has some sites / projects but not all
  2. Check that the bvl feedback widget on the dashboard only includes notifications for that users sites / projects
  3. Give the user the access_all_profiles permission, and check that the notifications no longer have the site restriction

@maltheism maltheism added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Oct 13, 2022
maltheism
maltheism requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@maltheism maltheism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CamilleBeau conflict with Changelog

@CamilleBeau CamilleBeau force-pushed the 2021-11-23-bvl_feedback_widget_project_site branch from 384d373 to 3c1d20e Compare November 1, 2022 18:31
@CamilleBeau CamilleBeau removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 1, 2022
@CamilleBeau
Copy link
Contributor Author

@maltheism Thank you Alizée! Rebased & conflicts resolved

@CamilleBeau CamilleBeau force-pushed the 2021-11-23-bvl_feedback_widget_project_site branch from 3c1d20e to 2f959ea Compare November 30, 2022 17:10
@cmadjar cmadjar added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 6, 2022
@CamilleBeau CamilleBeau force-pushed the 2021-11-23-bvl_feedback_widget_project_site branch from 31d9fa7 to 50e8ff2 Compare December 6, 2022 15:23
@CamilleBeau CamilleBeau removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Dec 6, 2022
driusan
driusan reviewed Dec 6, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@driusan driusan merged commit fa666f5 into aces:main Dec 13, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan left review comments

@maltheism maltheism maltheism approved these changes

Assignees

@CamilleBeau CamilleBeau

Labels
None yet
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CamilleBeau @driusan @maltheism @cmadjar @ridz1208