Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EEG Browser][Feature] Ability to add new annotations from module #7829

Closed
wants to merge 6 commits into from
Closed

[EEG Browser][Feature] Ability to add new annotations from module #7829

wants to merge 6 commits into from

Conversation

jesscall
Copy link
Contributor

@jesscall jesscall commented Nov 16, 2021 •
edited
Loading

Brief summary of changes

Disclaimer: This PR is blocked by #7828 and will need to be rebased after its merge.

This PR fills in some gaps in the code relating to EEG annotations. It connects the front-end architecture from #7433 to the annotation form that was added in #7387. The result is that a user can now add new annotations from the EEG Browser.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Will add details shortly.

Discussion Items:

  • Figure out metadata
  • Determine if annotation labels in form are sufficient
  • Talk about derivatives vs normal annotations

@jesscall jesscall added Category: Feature PR or issue that aims to introduce a new feature State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed labels Nov 16, 2021
@jesscall jesscall mentioned this pull request Nov 30, 2021
Closed
3 tasks
@jesscall jesscall mentioned this pull request Dec 7, 2021
Closed
@jesscall jesscall mentioned this pull request Jun 8, 2022
Open
@christinerogers christinerogers mentioned this pull request Nov 22, 2022
Closed
@laemtl laemtl removed the State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed label Nov 22, 2022
@laemtl laemtl mentioned this pull request Nov 22, 2022
Merged
@laemtl laemtl closed this Nov 22, 2022
driusan pushed a commit that referenced this pull request Dec 1, 2022
@laemtl
[EEG Browser] Annotations: Add new and HED tags (#8236)
f427144 
This fills in some gaps in the code relating to EEG annotations. It connects the front-end architecture from #7433 to the annotation form that was added in #7387. The result is that a user can now add new annotations from the EEG Browser.

Based on @jesscall's work in PR #7829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Feature PR or issue that aims to introduce a new feature State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesscall @laemtl