[Instrument] Add support for jsonData instrument in clearInstrument function #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this on MCNRR and it all looks good. |
driusan
reviewed
Jun 16, 2021
| $columns = $db->pselect( | ||
| "SELECT COLUMN_NAME FROM information_schema.columns | ||
| if ($this->jsonData) { | ||
| $db->update('flag', ['Data'=>null], ['CommentID' => $this->commentID]); |
There was a problem hiding this comment.
Shouldn't this update be unconditional? The Data column in the flag table exists regardless of whether jsonData is true or not, and the update when saving data in _save isn't conditional.
There was a problem hiding this comment.
You are correct. Ma bad
ridz1208
added
the
Passed manual tests
|
@driusan changes done |
|
Re-tested after the changes with MCNRR and it works alright. |
driusan
approved these changes
Jun 16, 2021
|
@driusan I think we should merge before @GabrielPelletier takes it from "alright" to "its not bad" |
|
I like a bit of variation; it makes for richer github Conversations, literature-wise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
clearInstrumentFunction gives an error when the instrument has jsonData enabled. this fix adds support for clearInstrument by clear the data from the proper locationPS, make sure to ignore white spaces changes as most changes here are just indentation
Testing instructions (if applicable)
Link(s) to related issue(s)