-
Notifications
You must be signed in to change notification settings - Fork 181
[filterable_datatable] Fix Query Param Filtering Bug #7245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filterable_datatable] Fix Query Param Filtering Bug #7245
Conversation
@HenriRabalais travis is still failing @kongtiaowang can you help |
@ridz1208 Yes, I tried |
|
@HenriRabalais I am looking into it. The integration test of media filter faild. |
Thanks @kongtiaowang !! |
@ridz1208 needs re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for 1 filter, but not 2, where only the second is considered.
@laemtl Could you provide a screenshot example? |
/battery_manager/?subproject=2&visitLabel=V1 |
@laemtl should be fixed now! |
@HenriRabalais Awesome, the problem is fixed! I found another small issue:
|
@HenriRabalais please fix when possible |
Brief summary of changes
This PR updates the functionality of the Filterable datatable by changing the way that it loads filters via the URL query params.
Instead of simply loading the query params into the filter object, upon component mount the query params will each trigger the update of the respective field they are associated with, if they exist.
The resolves the issue #7216 which was causing filters that were meant to be exact match filters to be treated as substring, or "partial", filters.
Testing instructions (if applicable)
1
when there are other subprojects in the list whose indexes are anywhere from 10-19).Link to related issue