Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0][document_repository] Fix for contents displayed at root #7233

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

jesscall
Copy link
Contributor

Brief summary of changes

Related to aces/CCNA#4302

Root directory of the doc repo should only contain files that are located at root. All other files will be in subfolders.
Can see all files by filtering globally.

This was a design decision made by Zal and Derek a while ago but was reverted in #6408.

Please see @zaliqarosli 's comment here

@jesscall jesscall requested a review from zaliqarosli December 16, 2020 20:15
@jesscall jesscall added 23.0.0-testing Category: Bug PR or issue that aims to report or fix a bug labels Dec 16, 2020
@driusan
Copy link
Collaborator

driusan commented Dec 16, 2020

@jesscall can you double check the test plan too to make sure it's accurate and we don't bounce back and forth on this?

@jesscall
Copy link
Contributor Author

Seems to be correct:

10. Check that when performing a search without global filtering, the resulting files which are under the current category are shown in a list format. [Manual Testing]
11. Check that when performing a search with global filtering, all files matching the filtered case (regardless of category) are shown in a list format. [Manual Testing]

Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this PR!

@zaliqarosli zaliqarosli added the Passed manual tests PR has been successfully tested by at least one peer label Dec 16, 2020
@driusan driusan merged commit aad10b8 into aces:23.0-release Dec 17, 2020
@ridz1208 ridz1208 added this to the 23.0.3 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants