[new profile] fix for single site affiliation bug #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapillonMcGill
suggested changes
Feb 3, 2020
|
@PapillonMcGill did you run make ? the change is in the react file |
|
yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Fix issue where empty dropdown shows up in the module when the logged in user is only affiliated to 1 site.
I'm not a big fan of hiding fields with a single option, but judging by the code, that was the expected behaviour. So this is the smallest possible change to fix the bug on 22
Testing instructions (if applicable)
Link(s) to related issue(s)