Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] PHPUNIT 6.5 to PHPUNIT 8 | php-ast 0.1.6 to php-ast 1.0.1| #4433

Closed
wants to merge 133 commits into from
Closed

[Test] PHPUNIT 6.5 to PHPUNIT 8 | php-ast 0.1.6 to php-ast 1.0.1| #4433

wants to merge 133 commits into from

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Mar 28, 2019 •
edited
Loading

Update PHPUNIT Version
Get rid of dbunit. This package is abandoned and no longer maintained.
The @ExpectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated.
They will be removed in PHPUnit 9.

To test: Travis

@kongtiaowang kongtiaowang added [branch] major Testing PR contains test plan or automated test code (or config files for Travis) labels Mar 28, 2019
@kongtiaowang kongtiaowang changed the title [test] PHPUNIT 6.5 to PHPUNIT 8 [Test] PHPUNIT 6.5 to PHPUNIT 8 Mar 28, 2019
johnsaigle
johnsaigle previously approved these changes Apr 1, 2019
View reviewed changes
driusan
driusan requested changes Apr 5, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@johnsaigle johnsaigle dismissed their stale review April 5, 2019 18:39

dave raises good points

@ridz1208 ridz1208 changed the base branch from major to 21.0-release May 13, 2019 16:06
@ridz1208 ridz1208 added this to the 21.0.0 milestone May 17, 2019
@ridz1208
Copy link
Collaborator

ridz1208 commented Jun 3, 2019

@driusan @kongtiaowang whats the status of this PR ?

@driusan
Copy link
Collaborator

driusan commented Jun 3, 2019

@ridz1208 it's still missing composer.lock

@ridz1208
Copy link
Collaborator

ridz1208 commented Jun 3, 2019

@kongtiaowang please make necessary changes

@ridz1208 ridz1208 removed this from the 21.0.0 milestone Jun 5, 2019
@johnsaigle johnsaigle added the State: Needs work PR awaiting additional work by the author to proceed label Jun 18, 2019
@kongtiaowang kongtiaowang changed the base branch from 21.0-release to major June 19, 2019 17:05
@kongtiaowang kongtiaowang added State: Needs work PR awaiting additional work by the author to proceed and removed State: Needs work PR awaiting additional work by the author to proceed labels Jun 19, 2019
@kongtiaowang kongtiaowang reopened this Oct 11, 2019
@kongtiaowang kongtiaowang added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Oct 15, 2019
@kongtiaowang
Copy link
Contributor Author

blocked by phan. It should be fixed on other PR.

@kongtiaowang kongtiaowang reopened this Oct 17, 2019
@johnsaigle
Copy link
Contributor

Needs PHPCS on FILE: /home/travis/build/aces/Loris/php/libraries/Utility.class.inc

@johnsaigle
Copy link
Contributor

Is this still blocked?

This was referenced Oct 21, 2019
Merged
Closed
@kongtiaowang
Copy link
Contributor Author

It still blocked for no reason.

@kongtiaowang
Copy link
Contributor Author

phpunit > 8.0 is not stable in Travis. failed without reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsaigle johnsaigle johnsaigle left review comments

@maltheism maltheism maltheism left review comments

@driusan driusan Awaiting requested review from driusan

@HenriRabalais HenriRabalais Awaiting requested review from HenriRabalais

@PapillonMcGill PapillonMcGill Awaiting requested review from PapillonMcGill

Assignees

@johnsaigle johnsaigle

@kongtiaowang kongtiaowang

Labels
State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed State: Needs work PR awaiting additional work by the author to proceed Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kongtiaowang @ridz1208 @driusan @johnsaigle @HenriRabalais @maltheism @PapillonMcGill @cmadjar