Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data_release] "Unversioned" permissions granted with every version #8741

Closed
CamilleBeau opened this issue Jun 8, 2023 · 1 comment
Closed

[data_release] "Unversioned" permissions granted with every version #8741

CamilleBeau opened this issue Jun 8, 2023 · 1 comment
Assignees
@charlottesce
Labels
25.0.0 - Bugs Category: Bug PR or issue that aims to report or fix a bug

Comments

@CamilleBeau
Copy link
Contributor

Describe the bug
When adding version permissions for a user, the "Unversioned" permission is also granted to that user unintentionally.

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to data_release
  2. Make sure that there is at least one file uploaded without a version (version will show up as "Unversioned"), and at least one file uploaded under a specified version
  3. Add permissions for a user to give them permission to the specified version
  4. See that the user now has permission to both the specified version, and "Unversioned"

What did you expect to happen?
When adding permissions to one version for a user, that user should have permission to only that version, and not "Unversioned". "Unversioned" should only be granted to a user if it is added as a permission on its own.
@CamilleBeau CamilleBeau added Category: Bug PR or issue that aims to report or fix a bug 25.0.0 - Bugs labels Jun 8, 2023
@CamilleBeau CamilleBeau mentioned this issue Jun 8, 2023
Closed
14 tasks
@charlottesce charlottesce mentioned this issue Jun 9, 2023
Merged
driusan pushed a commit that referenced this issue Jun 20, 2023
@charlottesce
[data_release] Permission not added to unversioned files if version s…
baac2f4 
…pecified (#8768)

When adding version permissions for a user, permissions for unversioned files are no longer added.

Resolves #8741
@driusan
Copy link
Collaborator

driusan commented Jun 20, 2023

PR was merged

@driusan driusan closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlottesce charlottesce

Labels
25.0.0 - Bugs Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driusan @CamilleBeau @charlottesce