Skip to content

Commit

Permalink
[Feedback] Fix typo in getSummaryOfThreads (#8889)
Browse files Browse the repository at this point in the history
This fixes the BVL Feedback summary in instruments by taking the
commentID for query params from the array _feedbackObjectInfo instead of
_feedbackCandidateProfileInfo, which only included candidate specific
data instead of instrument specific data.
  • Loading branch information
CamilleBeau authored Nov 11, 2024
1 parent cc6f1e8 commit 0254ec0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ the `Data` key instead of `$InstrumentName` (PR #7857)
- Fixed broken DB calls in `assign_missing_instruments` and `instruments` (PR #8162)
- Add support for PHP 8.1 (PR #7989)
- Fix Project tab of Configuration module to give correct errors, and prevent saving without Alias (PR #8349)
- Fix BVL feedback summary in instruments (PR #8889)
### Modules
#### API
- Ability to use PSCID instead of the CandID in the candidates API (PR #8138)
Expand Down
2 changes: 1 addition & 1 deletion php/libraries/NDB_BVL_Feedback.class.inc
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ class NDB_BVL_Feedback
}
if (!empty($this->_feedbackObjectInfo['CommentID'])) {
$query .= " AND ft.CommentID = :ComID";
$qparams['ComID'] = $this->_feedbackCandidateProfileInfo['CommentID'];
$qparams['ComID'] = $this->_feedbackObjectInfo['CommentID'];
}

if (!$hasReadPermission) {
Expand Down

0 comments on commit 0254ec0

Please sign in to comment.