-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical - Add Additional Hitpoints to the medical system #10482
base: master
Are you sure you want to change the base?
Conversation
addons/medical_treatment/functions/fnc_handleBandageOpening.sqf
Outdated
Show resolved
Hide resolved
If the upper limbs are called upper the lower limbs should be called lower. |
MIA |
I don't hate this on principle but oh dear this can break in so many ways (both itself and BWC) |
Co-authored-by: Filip Maciejewski <[email protected]>
I know, its horrible for BWC, but its a very much needed update as KAM needs more granularity in terms of hitpoints (and overwrites are not great I had a differing path as well, but that would have had me make hitpoints for everything, down to the granularity of individual hands and joints, which would have been worse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly few changes necessary to make this work (though I'll admit I haven't looked at this under a microscope), which is good, but this is a big enough change this late into the lifecycle that I'd put it under a setting. Which you can't do, because hitpoints are tied too strongly into how the system works and was balanced.
This warrants similar testing as the wound handler rework and medical rewrite IMO.
Some other considerations:
Do you bleed twice as much for explosions now? (I have a feeling you do)
Is sway just twice as strong on the worst case too?
This is a pretty big change so we're going to be nitpicky. You're going to see "Requested Changes" a lot. Sorry, not sorry (please use hemtt), I still have an armor penetration PR that hasn't been reviewed because no one wants to touch medical.
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Yes, but there is another PR in the pipe that reworks wounds and their creation, so in the end it will be equivalent to how it was before
Yes, and I'm looking at making a change to that |
Current issues Explosions are kinda weird for damage, likes to leave parts of limbs untouched, might need the damage randomizer to be a flip flop instead, unless its all one EH and if so ill need to work at explosive damage
|
Co-authored-by: Jouni Järvinen <[email protected]>
Current issue, explosions are one call of woundshandlerbase per hitpoint, and splitting it isn't fruitful, |
Explosions are fixed, did a new wounds handler |
{ | ||
private _damageData = _x; | ||
_damageData params ["_engineDamage", "_bodyPart", "_realDamage"]; | ||
switch (true) do { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hack ain't necessary here.
I'll review when I have time, which isn't going to be soon. I maintain that this is a hell of a change to how the system has worked for years and I'm not a fan personally. |
When merged this pull request will:
ToDo
-GUI
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.