Add support for longer update intervals #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load display-sizes from supported_models Cleanup old images on new run of Inkycal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load display-sizes from supported_models
Cleanup old images on new run of Inkycal
The changes this time are not perfect as calibrations may be skipped in some cases for update intervals less frequent than once per hour. However, update intervals are now officially supported up until once per day.
The said problem can be overcome by defining an active-time-range (e.g. 8am-5pm) and inactive-time range (5pm - 8am). Ideally, Inkycal should remember how many display updates have been done in total (not just first start). The user can then define after how many updates the display should be calibrated in the inactive-time-range. The recommended value is once per every six display updates. This will require changes in the settings.json and is therefore to be scheduled in the next release to avoid breaking changes.