ci: 👷 changed to building imagick from source #2428
Conversation
.kube/app/Dockerfile
Outdated
| @@ -1,6 +1,7 @@ | |||
| FROM php:8.4-fpm | |||
|
|
|||
| ENV PHP_VERSION 8.4 | |||
| ENV IMAGICK_VERSION 3.7.0 # This should be bumped to the latest version and | |||
There was a problem hiding this comment.
seems like part of the comment is missing
|
|
||
| RUN pecl install imagick | ||
| # START BUILDING IMAGICK FROM SOURCE - this can be removed once pecl fixes issues installing with php8.4 |
There was a problem hiding this comment.
Can you please leave a link to #2425 in the comments. It'll just make it easier to understand when scanning the code later.
.kube/app/Dockerfile
Outdated
| # - this can be removed once pecl fixes issues installing with php8.4 | ||
| RUN apt-get remove -y \ | ||
| $PHPIZE_DEPS \ | ||
| libtool |
There was a problem hiding this comment.
Is it possible to do the remove in the same block as the install? I think it's more likely this will get missed when reverting later.
There was a problem hiding this comment.
It needs to be there or the following pecl build commands fail. I thought those commands ensures build dependencies were installed if necessary when pecl runs, but it failed when I removed them prior to running those.
There was a problem hiding this comment.
Migrated to TODO comments which should be recognized by IDE's that implement finding the tags for pending items that are pending changes.
.kube/app/Dockerfile
Outdated
| @@ -1,6 +1,8 @@ | |||
| FROM php:8.4-fpm | |||
|
|
|||
| ENV PHP_VERSION 8.4 | |||
| # TODO - IMAGICK_VERSION can be removed once pecl fixes issues installing with php8.4 | |||
| ENV IMAGICK_VERSION 3.7.0 # This should be bumped to the latest version, especially when PHP version is bumped and can be removed when https://github.com/accessibility-exchange/platform/issues/2425 is resolved | |||
There was a problem hiding this comment.
I guess this link is a bit odd because this PR will close that issue. Maybe reword a bit here so that it indicates that 2425 is what this work around is for an can be removed when the upstream issue in imagick is resolved (and link to an imagick issue).
There was a problem hiding this comment.
Changed all the TODO comments to reference issue Imagick/imagick#698.
Updated Dockerfile that builds the main application image to build the imagick library from source instead of using
peclsince their version is not yet fully ready for php v8.4.