Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings matching information #1460

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Jan 10, 2023

What this PR does

  • Fix teal border not handled by contrast themes
  • Create a policy to only show to individual users and for now only on local and dev environments
  • Use the policy to restrict access to the matching/demographics route
  • Add link to matching from an Individual user's settings page
  • Use the policy to restrict displaying matching link
  • Enabled password confirmation middleware on matching/demographics route
  • Style/update password confirmation dialog as needed, if possible
  • Implement matching "landing" page
  • Implement matching "add/edit" page
  • Implement placeholder for "how matching works" page

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1460 (e12a6e5) into dev (9e07ca8) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #1460      +/-   ##
============================================
- Coverage     96.56%   96.46%   -0.10%     
- Complexity     1841     1844       +3     
============================================
  Files           282      282              
  Lines          5994     6000       +6     
============================================
  Hits           5788     5788              
- Misses          206      212       +6     
Impacted Files Coverage Δ
app/Http/Controllers/SettingsController.php 96.77% <0.00%> (-2.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant