fix: #98 retries can be picked up by wrong handler #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acaloiaro
commented
Oct 20, 2023
| p.announceJob(ctx, queue, jid) | ||
| }(jobID) | ||
| p.announceJob(ctx, j.Queue, jid) | ||
| }(jobID, job) |
There was a problem hiding this comment.
This was the crux of the bug. queue was captured by the above function, but queue was not necessarily the the job's queue.
acaloiaro
commented
Oct 20, 2023
| @@ -31,21 +31,20 @@ import ( | |||
| var migrationsFS embed.FS | |||
|
|
|||
| const ( | |||
| PendingJobIDQuery = `SELECT id | |||
| JobQuery = `SELECT id,fingerprint,queue,status,deadline,payload,retries,max_retries,run_after,ran_at,created_at,error | |||
There was a problem hiding this comment.
The diff does a poor job of explaining this change. I've eliminated PendingJobQuery and replaced it with JobQuery, which has fewer filters, and should perform better.
Because of the setting in which PendingJobQuery was executed, it never needed to have the filter run_after <= NOW(). When that query is executed, the jobID is already pre-vetted as a pending job.
acaloiaro
force-pushed
the
fix-98-retries-picked-up-by-wrong-handler
branch
from
cbcf27e to
f854991
Compare
acaloiaro
force-pushed
the
fix-98-retries-picked-up-by-wrong-handler
branch
2 times, most recently
from
7a3e7ac to
6a48598
Compare
Fixes a bug that can allow retries to end up on the wrong queue in settings where there are multiple handlers.
acaloiaro
force-pushed
the
fix-98-retries-picked-up-by-wrong-handler
branch
from
6a48598 to
4ec478c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98