Add a command to replace needs with injection

[paddyobrien]

Relates to #85

Replace:

needs: ['foo'],
fooModel: Em.computed.alias('controllers.foo.model')

With

fooController: Em.inject.controller('foo'),
fooModel: Em.computed.alias('fooController.model')

I had a need for this in our internal project so I took it on today. I'm completely new to the recast AST API so I may be using it sub-optimally. Also some of the decisions I've made with regard to renaming might only make sense in the context of our project.

I was unsure how to approach the template aspect of this so I've ignored it.

I'm happy to change anything that seems incorrect.

[abuiles]

Thanks! I'll review this latter today and get it in :)

[abuiles]

@paddyobrien

Also some of the decisions I've made with regard to renaming might only make sense in the context of our project.

Could you elaborate more about those ones?

[GavinJoyce]

@abuiles I think he's referring to both the addition of the Controller suffix to avoid naming collisions with other properties and the support for handling duplicate leaf route names:

import Em from 'ember';

export default Ember.Controller.extend({
  fooBarController: Em.inject.controller('foo/bar'),
  bazBarController: Em.inject.controller('baz/bar')
});

[paddyobrien]

Yep exactly that.

On Monday, October 5, 2015, Gavin Joyce [email protected] wrote:

@abuiles https://github.com/abuiles I think he's referring to both the
addition of the Controller suffix (to avoid naming collisions) and
support for handling duplicate leaf route names:

import Em from 'ember';
export default Ember.Controller.extend({
fooBarController: Em.inject.controller('foo/bar'),
bazBarController: Em.inject.controller('baz/bar')
});

[image: image]
https://cloud.githubusercontent.com/assets/2526/10291604/a6f19d5c-6ba2-11e5-9328-30a1b83533ce.png

—
Reply to this email directly or view it on GitHub
#87 (comment).

[abuiles]

@paddyobrien finally went through this and it looks great, I didn't realized but I've been also using somethingController: Ember.inject.controller('something') so let's ship it like it.

Can you do me a last favor, can you add the command to the readme with a brief description, I'll release after that, 👍

[paddyobrien]

@abuiles done, thanks for the quick review!