Yield assert into the beforeEach/afterEach callbacks #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamal
force-pushed
the
assert-in-before-each
branch
from
bb0a321
to
a72ca3b
Compare
| tests: [], | ||
| skips: [], | ||
| assertions: [] | ||
| }; | ||
|
|
||
| var ast = recast.parse(source); | ||
| var isInSetup = false; |
There was a problem hiding this comment.
I'm in general 👎 on using this kind of globals, since we already keep track of the modules what if we do a second transverse at the end for every module, analyzing whether we should replace the callbacks or not?
There was a problem hiding this comment.
Cool I can do that if I can figure out how to perform a second traverse.
There was a problem hiding this comment.
@kamal recast.visit(node, {}) :)
|
@kamal sorry for my delay here! Can you please address my comment and then I think we are good to go :) |
kamal
force-pushed
the
assert-in-before-each
branch
from
a72ca3b
to
063852f
Compare
|
@abuiles please review again. i recast again within |
abuiles
added a commit
that referenced
this pull request
Apr 5, 2015
Yield assert into the beforeEach/afterEach callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But only if they contain assertions