Add support for Absinthe continuations #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardd
force-pushed
the
defer-directive-support
branch
from
03e3bf3 to
50323ef
Compare
bernardd
force-pushed
the
defer-directive-support
branch
2 times, most recently
from
4a2b3a3 to
a0a0a8d
Compare
bernardd
force-pushed
the
defer-directive-support
branch
from
a0a0a8d to
aea8ce6
Compare
bernardd
force-pushed
the
defer-directive-support
branch
from
aea8ce6 to
9d147dd
Compare
bernardd
force-pushed
the
defer-directive-support
branch
from
9d147dd to
1a3991f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for continuations and the
@deferdirective as implemented in absinthe-graphql/absinthe#559. It's not meant to be merged until that one's all done (the dependency inmix.exswill need updating), but I figured I'd put it here now so that it's ready to go.Of note: There's support for asynchronous handling of continuations (as discussed in absinthe-graphql/absinthe#559 (comment)), but it's off by default. To enable it, the endpoint can be started with the
max_async_procsflag (seesocket/1inasync_test.exs), specifying the maximum number of temporary processes used to handle asynchronous queries. Beyond that number, queries using@deferwill be blocked as usual on long running requests.