Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional_callback handle_ping #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bnhansn
Copy link

@bnhansn bnhansn commented Sep 12, 2022

The graphql-ws spec mentions a Ping message may be useful for detecting failed connections or other types of network probing.

To allow an application to hook into this feature, this PR adds:

  • An optional handle_ping callback in the socket implementation.
  • Updates the Pong response to include the same payload that was sent in the Ping.

@aloukissas
Copy link

Hey @sax - what can we do to merge this? This seems useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants