Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task implementation for async configurable #1349

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drtheuns
Copy link

@drtheuns drtheuns commented Dec 8, 2024

Projects that don't use open-telemetry or with more complex process propagation requirements can now implement it themselves by configuring the Task module to use.

Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine idea but we definitely want this to be compile time.

lib/absinthe/utils.ex Outdated Show resolved Hide resolved
@drtheuns
Copy link
Author

drtheuns commented Dec 9, 2024

The first time Absinthe compiles (e.g. on CI) it will give a warning about the configured module not existing (yet). I haven't tried but it might be possible to get around this with apply. I personally don't think it's an improvement, but I could try it out if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants