Improve WebAssembly detection when using Bazel.#1129
Closed
PiotrSikora wants to merge 1 commit intoabseil:masterfrom
Closed
Improve WebAssembly detection when using Bazel.#1129PiotrSikora wants to merge 1 commit intoabseil:masterfrom
PiotrSikora wants to merge 1 commit intoabseil:masterfrom
Conversation
Author
|
cc @derekmauro |
Unfortunately, the --cpu values are not standardized, and both
--cpu=wasm and --cpu=wasm32 are used in the wild. Most notably,
Emscripten's Bazel rules use --cpu=wasm, which was missing.
While there, add support for @platforms//cpu:{wasm32,wasm64}.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Member
|
@PiotrSikora - As per https://github.com/abseil/abseil-cpp/blob/master/CONTRIBUTING.md
Can you please send an internal CL instead? |
Author
|
Internal change pushed in eb3db08. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the --cpu values are not standardized, and both
--cpu=wasm and --cpu=wasm32 are used in the wild. Most notably,
Emscripten's Bazel rules use --cpu=wasm, which was missing.
While there, add support for @platforms//cpu:{wasm32,wasm64}.
Signed-off-by: Piotr Sikora piotrsikora@google.com