cmake: add ABSL_BUILD_TESTING option #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matta
force-pushed
the
master
branch
2 times, most recently
from
55db3de
to
59edbc8
Compare
Abseil's own tests now are disabled if either BUILD_TESTING or a new option called ABSL_BUILD_TESTING is false. Additionally, Abseil's CMakeLists.txt no longer re-declares the BUILD_TESTING option with a value of false. Abseil had been using just the BUILD_TESTING option, since the fix for abseil#901. Because setting BUILD_TESTING false still works to disable Abseil's tests, this change preserves the behavior asked for in that issue. Previous to that, Abseil had a project specific flag for this, as is the typical idiom used in other projects. The issue with BUILD_TESTING is that it is an all-or-nothing policy. When Abseil is incorporated as a subproject, the encompasing project has no convenient way to enable its own tests while disabling Abseil's. Fixes abseil#1056
|
Greetings! JFYI, the "getting started" instructions on abseil.io still direct users to use -DBUILD_TESTING=on to get started running abseil's tests: https://abseil.io/docs/cpp/quickstart-cmake#getting-the-abseil-code. I'm not sure the abseil.github.io repo is accepting pull requests; so figured I'd let you know here. |
See #1079 - I've submitted a docs update. It should make it to GitHub soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abseil's own tests now are disabled if either BUILD_TESTING
or a new option called ABSL_BUILD_TESTING is false.
Additionally, Abseil's CMakeLists.txt no longer re-declares
the BUILD_TESTING option with a value of false.
Abseil had been using just the BUILD_TESTING option, since
Previous to that, Abseil had a project specific flag for
this, as is the typical idom used in other projects.
BUILD_TESTING is a simplistic all-or-nothing policy that
suffices for simpler projects. When Abseil is incorporated
as a subproject, the encompasing build has no convenient way
to disable just Abseil's tests by default, yet enable its
own.
Fixes #1056