Skip to content

Commit

Permalink
Update GoogleTest dependency to 1.15.2 (#1736)
Browse files Browse the repository at this point in the history
This updates to a version of GoogleTest that fixes
google/googletest#4581
for downstream users of rules_python

Cherry-pick of d0159ea
  • Loading branch information
derekmauro authored Aug 1, 2024
1 parent 7e5c339 commit 4447c75
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ bazel_dep(name = "google_benchmark",
dev_dependency = True)

bazel_dep(name = "googletest",
version = "1.15.0",
version = "1.15.2",
repo_name = "com_google_googletest")

bazel_dep(name = "platforms",
Expand Down
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# GoogleTest/GoogleMock framework. Used by most unit-tests.
http_archive(
name = "com_google_googletest",
sha256 = "7315acb6bf10e99f332c8a43f00d5fbb1ee6ca48c52f6b936991b216c586aaad",
strip_prefix = "googletest-1.15.0",
sha256 = "7b42b4d6ed48810c5362c265a17faebe90dc2373c885e5216439d37927f02926",
strip_prefix = "googletest-1.15.2",
# Keep this URL in sync with the version in ci/cmake_common.sh and
# ci/windows_msvc_cmake.bat.
urls = ["https://github.com/google/googletest/releases/download/v1.15.0/googletest-1.15.0.tar.gz"],
urls = ["https://github.com/google/googletest/releases/download/v1.15.2/googletest-1.15.2.tar.gz"],
)

# RE2 (the regular expression library used by GoogleTest)
Expand Down
2 changes: 1 addition & 1 deletion ci/cmake_common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@

# The commit of GoogleTest to be used in the CMake tests in this directory.
# Keep this in sync with the commit in the WORKSPACE file.
readonly ABSL_GOOGLETEST_VERSION="1.15.0"
readonly ABSL_GOOGLETEST_VERSION="1.15.2"

readonly ABSL_GOOGLETEST_DOWNLOAD_URL="https://github.com/google/googletest/releases/download/v${ABSL_GOOGLETEST_VERSION}/googletest-${ABSL_GOOGLETEST_VERSION}.tar.gz"
2 changes: 1 addition & 1 deletion ci/windows_msvc_cmake.bat
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ SETLOCAL ENABLEDELAYEDEXPANSION

:: The version of GoogleTest to be used in the CMake tests in this directory.
:: Keep this in sync with the version in the WORKSPACE file.
SET ABSL_GOOGLETEST_VERSION=1.15.0
SET ABSL_GOOGLETEST_VERSION=1.15.2
SET ABSL_GOOGLETEST_DOWNLOAD_URL=https://github.com/google/googletest/releases/download/v%ABSL_GOOGLETEST_VERSION%/googletest-%ABSL_GOOGLETEST_VERSION%.tar.gz

:: Replace '\' with '/' in Windows paths for CMake.
Expand Down

0 comments on commit 4447c75

Please sign in to comment.