This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Fix error handling when unknown exception occurs in run_crash_cmd #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
If an unknown error occurs the following cryptic error is thrown: [2020-01-29 17:11:52] [I] Searching for kernel-debuginfo package for 2.6.32-504.el6.x86_64 [2020-01-29 17:11:52] [E] not enough arguments for format string The intent was to print out more info about the exception, and fixing this bug shows better info: [2020-01-29 17:30:15] [I] Searching for kernel-debuginfo package for 2.6.32-504.el6.x86_64 [2020-01-29 17:30:15] [W] crash command: 'mod; quit' triggered Unknown exception stdin and input arguments may not both be used. [2020-01-29 17:30:15] [W] <class 'ValueError'> [2020-01-29 17:30:15] [E] prepare_debuginfo failed: 'NoneType' object has no attribute 'decode' Signed-off-by: Dave Wysochanski <[email protected]>
This fixes a small problem caused by the conversion from Popen to run in commit fd40267 where run_crash_cmdline may fail with the following error: crash command: 'mod; quit' triggered Unknown exception stdin and input arguments may not both be used. Signed-off-by: Dave Wysochanski <[email protected]>
DaveWysochanskiRH
force-pushed
the
fix-prepare-debuginfo-failure
branch
from
e140447
to
b319f0a
Compare
|
@trapas add to whitelist |
|
Thank you very much! Seems like we really need some proper tests for retrace-server. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an unknown error occurs the following cryptic error is thrown:
[2020-01-29 17:11:52] [I] Searching for kernel-debuginfo package for 2.6.32-504.el6.x86_64
[2020-01-29 17:11:52] [E] not enough arguments for format string
The intent was to print out more info about the exception, and
fixing this bug shows better info:
[2020-01-29 17:30:15] [I] Searching for kernel-debuginfo package for 2.6.32-504.el6.x86_64
[2020-01-29 17:30:15] [W] crash command: 'mod; quit' triggered Unknown exception stdin and input arguments may not both be used.
[2020-01-29 17:30:15] [W] <class 'ValueError'>
[2020-01-29 17:30:15] [E] prepare_debuginfo failed: 'NoneType' object has no attribute 'decode'
Signed-off-by: Dave Wysochanski [email protected]