-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --auth-response
option and expose through entrypoint.sh
#1628
Conversation
This allows for the use of the `--auth-files` switch in the docker environment.
@wrmilling In terms of when this PR will be merged into 'master', most likely after #1494 is merged. I would PR merge this before that change, however, I am too far along the journey to stop, merge, backtrack then revisit all the language change code. |
Also add in more logging to compensate for not outputting commands. This was done so that the ONEDRIVE_AUTHRESPONSE would not be logged to stdout.
Hello @abraunegg. thanks for throwing this on the next milestone. I have been testing out these changes via a new docker image which can be found here. The changes include what is in this PR as well as building a multi-arch image for arm64+amd64. If the multi-arch image is of interest (as well as the automated building + pushing of the images), please let me know. I would be happy to spin up a new PR with just the image and/or ci+cd changes. Also, if you are curious about the helm chart this is being used in, it is documented here. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request attempts the following two goals:
--auth-response
command line switch which takes in the responseUrl directly.--auth-files
and--auth-response
command line switches through the docker images as environment variables.This is to support using the docker images as part of a helm release deployed to Kubernetes, given the inability to interact with the terminal as part of initial startup.
Please let me know if you have any questions and thank you for your consideration.