Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --auth-response option and expose through entrypoint.sh #1628

Merged
merged 13 commits into from
Nov 22, 2021

Conversation

wrmilling
Copy link
Contributor

This pull request attempts the following two goals:

  • Create a new --auth-response command line switch which takes in the responseUrl directly.
  • Expose both --auth-files and --auth-response command line switches through the docker images as environment variables.

This is to support using the docker images as part of a helm release deployed to Kubernetes, given the inability to interact with the terminal as part of initial startup.

Please let me know if you have any questions and thank you for your consideration.

@abraunegg
Copy link
Owner

@wrmilling
Thanks for the PR, will review further when I have time.

In terms of when this PR will be merged into 'master', most likely after #1494 is merged. I would PR merge this before that change, however, I am too far along the journey to stop, merge, backtrack then revisit all the language change code.

@abraunegg abraunegg added this to the v2.4.14 milestone Sep 13, 2021
@abraunegg abraunegg linked an issue Sep 13, 2021 that may be closed by this pull request
Also add in more logging to compensate for not outputting commands. 
This was done so that the ONEDRIVE_AUTHRESPONSE would not be logged to stdout.
@wrmilling
Copy link
Contributor Author

Hello @abraunegg. thanks for throwing this on the next milestone.

I have been testing out these changes via a new docker image which can be found here. The changes include what is in this PR as well as building a multi-arch image for arm64+amd64. If the multi-arch image is of interest (as well as the automated building + pushing of the images), please let me know. I would be happy to spin up a new PR with just the image and/or ci+cd changes.

Also, if you are curious about the helm chart this is being used in, it is documented here.

@abraunegg abraunegg merged commit 5d7e453 into abraunegg:master Nov 22, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Environment Variables add authUrl and responseUrl
2 participants