-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement international language support #1494
Open
abraunegg
wants to merge
23
commits into
master
Choose a base branch
from
implement-language-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fe2f101
WIP: Implement international language support
abraunegg 7f92f2b
update
abraunegg eae4bba
updates
abraunegg aa97a9c
updates
abraunegg 99d6c8b
Update PR from 'master'
abraunegg bdeeb6f
Update translations.d
abraunegg 3714756
Update PR
abraunegg a8e33f4
Merge branch 'master' into implement-language-support
abraunegg fc3dba3
Merge branch 'master' into implement-language-support
abraunegg 23bdd6d
Update PR
abraunegg 854b45b
Merge branch 'master' into implement-language-support
abraunegg 8431d89
Update PR
abraunegg 6c5927d
Update PR
abraunegg 415d4cc
Update PR
abraunegg e534d18
Merge branch 'master' into implement-language-support
abraunegg 09a904a
Merge branch 'master' into implement-language-support
abraunegg 69efb0e
Update PR
abraunegg 0728b1d
Update PR
abraunegg 74235b7
Update PR
abraunegg 820e4b1
Update PR
abraunegg 5c04e35
Update PR
abraunegg fb3986c
Update PR from 'master'
abraunegg 81e7fbb
Merge branch 'master' into implement-language-support
abraunegg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
--- | ||
--- | ||
github: abraunegg |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"language": "DE", | ||
"list": [ | ||
{ | ||
"1": "Keine Benutzer- oder Systemkonfigurationsdatei gefunden, die Anwendungsstandardwerte verwendet", | ||
"2": "Systemkonfigurationsdatei erfolgreich geladen", | ||
"3": "Die Systemkonfigurationsdatei weist Fehler auf. Bitte überprüfen Sie Ihre Konfiguration", | ||
"4": "Konfigurationsdatei erfolgreich geladen", | ||
"5": "Konfigurationsdatei hat Fehler - bitte überprüfen Sie Ihre Konfiguration", | ||
"6": "Verwenden der Konfigurationsoption für globale Azure AD-Endpunkte", | ||
"7": "Verwenden der Konfigurationsoption für Azure AD für Endpunkte der US-Regierung", | ||
"8": "Verwenden der Konfigurationsoption für Azure AD für US Government Endpoints (DOD)", | ||
"9": "Verwenden der Konfigurationsoption für Azure AD Germany", | ||
"10": "Verwenden der Konfigurationsoption für Azure AD China, das von 21Vianet betrieben wird", | ||
"11": "Unbekannter Azure AD-Endpunkt – mit globalen Azure AD-Endpunkten", | ||
"12": "Unbekannter Schlüssel in der Konfigurationsdatei: ", | ||
"13": "Fehlerhafte Konfigurationszeile: ", | ||
"14": "Die Konfigurationsdatei wurde aktualisiert und überprüft, ob --resync erforderlich ist", | ||
"15": "Eine Änderung der Anwendungskonfiguration wurde festgestellt, wenn eine --resync erforderlich ist", | ||
"16": "DRY-RUN Konfiguriert. Die folgende Ausgabe zeigt, was passiert wäre", | ||
"17": "Verwenden des Protokolldateiverzeichnisses: ", | ||
"18": "Datenbankschema geändert, Resync erforderlich", | ||
"19": "Gespeicherten Status löschen ...", | ||
"20": "FEHLER: Microsoft OneDrive-API-Dienst kann nicht erreicht werden, Anwendung kann nicht initialisiert werden" | ||
|
||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"language": "EN-US", | ||
"list": [ | ||
{ | ||
"1": "No user or system config file found, using application defaults", | ||
"2": "System configuration file successfully loaded", | ||
"3": "System configuration file has errors - please check your configuration", | ||
"4": "Configuration file successfully loaded", | ||
"5": "Configuration file has errors - please check your configuration", | ||
"6": "Using config option for Global Azure AD Endpoints", | ||
"7": "Using config option for Azure AD for US Government Endpoints", | ||
"8": "Using config option for Azure AD for US Government Endpoints (DOD)", | ||
"9": "Using config option for Azure AD Germany", | ||
"10": "Using config option for Azure AD China operated by 21Vianet", | ||
"11": "Unknown Azure AD Endpoint - using Global Azure AD Endpoints", | ||
"12": "Unknown key in config file: ", | ||
"13": "Malformed config line: ", | ||
"14": "config file has been updated, checking if --resync needed", | ||
"15": "An application configuration change has been detected where a --resync is required", | ||
"16": "DRY-RUN Configured. Output below shows what 'would' have occurred", | ||
"17": "Using logfile dir: ", | ||
"18": "Database schema changed, resync needed", | ||
"19": "Deleting the saved status ...", | ||
"20": "ERROR: Unable to reach Microsoft OneDrive API service, unable to initialize application" | ||
|
||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I just saw this PR, did you by chance create the german translation automatically?
I think at least the first log message sounds a bit off.
I think this sounds better:
"Keine Benutzer- oder Systemkonfigurationsdatei gefunden, es werden die Standardwerte verwendet"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oohjio
Many thanks for looking at this PR in its very early stage of development.
This is a WIP at the moment. The DE.json is just a 'google' translate of the first few messages, so that I can ensure, when building the PR (as it is not complete), is able to provide the right 'translations' for the language being selected. I could have also used dummy text (eg 'asdfasdfasfdasfdasdf') .. but I didnt.
When this PR is ready, there will only be the EN-US.json file, with the community able to provide a language.json file, which then can be used / loaded into the application for folks to use.
Please keep an eye on this, and if you are interested in providing the DE.json when the main code changes are done, please create / update the file so that this feature can launch with accurate & correct language translations for Deutsche.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abraunegg
Thanks for the reply.
I see, that makes sense,
Will keep an eye on this.