Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Changelog
=========

Version v31.0.0
----------------

- Raise instead of returning ``NotImplementedError`` in ``version_range.VersionRange`` methods. https://github.com/aboutcode-org/univers/pull/158

Version v30.12.1
----------------

Expand Down
8 changes: 4 additions & 4 deletions src/univers/version_range.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ def from_native(cls, string):
Return a VersionRange built from a scheme-specific, native version range
``string``. Subclasses can implement.
"""
return NotImplementedError
raise NotImplementedError

@classmethod
def from_natives(cls, strings):
"""
Return a VersionRange built from a ``strings`` list of scheme-
specific native version range strings. Subclasses can implement.
"""
return NotImplementedError
raise NotImplementedError

def to_native(self, *args, **kwargs):
"""
Expand All @@ -95,7 +95,7 @@ def to_native(self, *args, **kwargs):
extra arguments (such as a package name that some scheme may require
like for deb and rpm.)
"""
return NotImplementedError
raise NotImplementedError

@classmethod
def from_string(cls, vers, simplify=False, validate=False):
Expand Down Expand Up @@ -176,7 +176,7 @@ def from_versions(cls, sequence):
such as ["3.0.0", "1.0.1b", "3.0.2", "0.9.7a", "1.1.1ka"]
"""
if not cls.scheme or not cls.version_class:
return NotImplementedError
raise NotImplementedError

constraints = []
for version in sequence:
Expand Down