Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pygments lexing #20

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Add support for Pygments lexing #20

merged 6 commits into from
Apr 24, 2024

Conversation

pombredanne
Copy link
Member

With Pygments we can now collect source symbols, strings and comments.

Reference: aboutcode-org/purldb#388

Signed-off-by: Philippe Ombredanne <[email protected]>
- We now use source_symbols, source_strings and source_comments
across all the various options.

- Each option is now excluding the other options

Signed-off-by: Philippe Ombredanne <[email protected]>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne LGTM, few minor nits for your consideration.

setup.cfg Outdated Show resolved Hide resolved
src/source_inspector/symbols_pygments.py Outdated Show resolved Hide resolved
tests/test_symbols_pygments.py Outdated Show resolved Hide resolved
pombredanne and others added 3 commits April 24, 2024 18:27
Signed-off-by: Philippe Ombredanne <[email protected]>

Co-authored-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>

Co-authored-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>

Co-authored-by: Keshav Priyadarshi <[email protected]>
@pombredanne
Copy link
Member Author

@keshav-space Thanks for the review... All nits applied.

@keshav-space
Copy link
Member

Merging!

@keshav-space keshav-space merged commit 0c36cb7 into main Apr 24, 2024
6 checks passed
@keshav-space keshav-space deleted the pygments branch April 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants