Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed conclusions module #520

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Removed conclusions module #520

merged 3 commits into from
Jun 9, 2022

Conversation

OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Apr 21, 2022

Fixes #512

Signed-off-by: Omkar Phansopkar [email protected]

@OmkarPh
Removed conclusions module
0026480 
Signed-off-by: Omkar Phansopkar <[email protected]>
@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Apr 21, 2022

Hi @pombredanne
I've removed conclusions from the application.
Should I remove from the docs too

OmkarPh added 2 commits April 21, 2022 23:20
@OmkarPh
Removed mistakenly added conclusions.json
5564589 
Signed-off-by: Omkar Phansopkar <[email protected]>
@OmkarPh
Remove conclusion from docs
0244dec 
Signed-off-by: Omkar Phansopkar <[email protected]>
@AyanSinhaMahapatra
Copy link
Member

Looks LGTM to me. Thanks @OmkarPh!

I could build and use workbench all right from this branch (with no sign of the conclusions module).

Any idea why the CI didn't run here but it did in #519 ?

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented May 12, 2022 •
edited
Loading

Any idea why the CI didn't run here but it did in #519 ?

I'm clueless 🤔

@pombredanne
Copy link
Member

LGTM. We need to reinstate the CI run though.

@pombredanne pombredanne merged commit c60f024 into aboutcode-org:develop Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-esser steven-esser steven-esser approved these changes

@johnmhoran johnmhoran Awaiting requested review from johnmhoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove editable conclusions features
4 participants
@OmkarPh @AyanSinhaMahapatra @pombredanne @steven-esser