fix: change version number in field "key" for code-credit-license-1.0-0

[leoreinmann]

Fixes #4415

The key "code-credit-license-1.0-0" seems to be a typo because in the "short_name", the "name "and also the license text the version number is "1.0.0 ". The other licenses code-credit-license-1.0.1. and code-credit-license-1.1.0 have the semantic versioning pattern. Also on their website all their licenses use semantic versioning.

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁
• Updated documentation pages (if applicable)
• Updated CHANGELOG.rst (if applicable)

[AyanSinhaMahapatra]

Thanks @leoreinmann

Could you also chnage the license filename to fix the failing tests?
src/licensedcode/data/licenses/code-credit-license-1.0-0.LICENSE -> src/licensedcode/data/licenses/code-credit-license-1.0.0.LICENSE

[leoreinmann]

@AyanSinhaMahapatra Yes, I've noticed it and changed it with the second commit 😄

[AyanSinhaMahapatra]

Actually on further thought, we usually deprecate the license if the license key has a bug, and create a new license with the correct key and filename (with the same data verbatim) because:

• this preserves the link to the license/licenseDB and the license key, since there are still people using old scancode versions where this could be detected.

@pombredanne what do you think?

[DennisClark]

@AyanSinhaMahapatra and @pombredanne i think it's probably ok to update the license key in this case; it's a license that is very likely not used.

[leoreinmann]

@AyanSinhaMahapatra Are the failing tests related to the PR?

[AyanSinhaMahapatra]

@leoreinmann no the test failures are related to #4369,
this is all good to merge now. Thanks++