Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename license match attribute for spdx expression #3851

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Rename license match attribute for spdx expression #3851

merged 5 commits into from
Oct 20, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jul 5, 2024 •
edited
Loading

Reference: #3838

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the rename_match_spdx_expression_3838 branch 2 times, most recently from 4d20a95 to c568766 Compare July 5, 2024 11:28
pombredanne
pombredanne approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AyanSinhaMahapatra
Rename license match attribute for spdx expression
8a0a030 
Reference: #3838
Reported-by: Armijn Hemel
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the rename_match_spdx_expression_3838 branch from c568766 to d26142c Compare October 19, 2024 11:16
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the rename_match_spdx_expression_3838 branch from d26142c to 9da6fb2 Compare October 20, 2024 11:36
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 20f3794 into develop Oct 20, 2024
39 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the rename_match_spdx_expression_3838 branch October 20, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne